Skip to content

Conversation

@icecrasher321
Copy link
Collaborator

@icecrasher321 icecrasher321 commented Jan 16, 2026

Summary

  • Can switch to advanced at the subblock level. Also have a box to show advanced fields instead of gear icon in the top.
  • Hide Form Deploy from Docs
  • Serializer cleanup
  • Preprocessing Checks for different async trigger paths consolidated, removed redundant checks
  • Schedule / Webhook Lifecycle management should work with deployment versions activations / deactivations, etc

Type of Change

  • Other: UX Improvement + Code refactor

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Jan 16, 2026 11:00pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 16, 2026

Greptile Summary

  • Introduces canonical subblock system enabling advanced/basic mode switching at individual field level rather than block-wide, improving UX by allowing users to selectively show advanced options
  • Consolidates environment variable resolution and preprocessing checks across async execution paths (schedules, webhooks, workflows) to eliminate code duplication
  • Makes schedules and webhooks deployment version-aware by linking them to specific deployment versions, enabling proper lifecycle management during version activations/deactivations

Important Files Changed

Filename Overview
apps/sim/lib/workflows/subblocks/visibility.ts New visibility management module implementing the canonical subblock system with comprehensive functionality for grouping related subblocks, resolving visibility conditions, and managing mode overrides
apps/sim/serializer/index.ts Refactored to use centralized visibility utilities and introduce canonical mode support with per-subblock advanced/basic mode toggle capabilities
packages/db/migrations/0145_messy_archangel.sql Database migration adding deployment version support to webhooks and schedules, linking them to specific deployment versions rather than workflow blocks
apps/sim/executor/utils/reference-validation.ts New consolidated environment variable resolution function with configurable options replacing duplicated logic across execution paths
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/editor.tsx Major UI refactor implementing canonical subblock functionality with per-field advanced mode switching and improved advanced fields display

Confidence score: 4/5

  • This PR is generally safe to merge but requires careful review due to significant architectural changes in subblock visibility and deployment versioning
  • Score reflects the complexity of canonical subblock system integration, database schema changes for deployment versioning, and extensive refactoring across multiple execution paths - while well-implemented, the scope warrants thorough testing
  • Pay close attention to the new visibility module, database migration, and serializer changes as they affect core workflow functionality

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

44 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@icecrasher321
Copy link
Collaborator Author

@greptile

@icecrasher321
Copy link
Collaborator Author

@greptile

…block

# Conflicts:
#	apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/sub-block.tsx
@icecrasher321 icecrasher321 changed the title improvement(serializer): canonical subblock, serialization cleanups improvement(serializer): canonical subblock, serialization cleanups, schedules/webhooks are deployment version friendly Jan 16, 2026
@icecrasher321
Copy link
Collaborator Author

@greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

70 files reviewed, 5 comments

Edit Code Review Agent Settings | Greptile

@icecrasher321 icecrasher321 merged commit 78e4ca9 into staging Jan 16, 2026
11 checks passed
@waleedlatif1 waleedlatif1 deleted the feat/canonical-subblock branch January 17, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants